Provision SSM parameters for One Login secrets#2103
Open
stephencdaly wants to merge 1 commit intomainfrom
Open
Provision SSM parameters for One Login secrets#2103stephencdaly wants to merge 1 commit intomainfrom
stephencdaly wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds new AWS SSM Parameter Store entries in the forms-runner Terraform module to hold GOV.UK One Login credentials (client ID + private key) per environment, without wiring them into the running service yet.
Changes:
- Provision
/forms-runner-${env}/...SecureString parameters for One Login client ID and private key - Use
lifecycle.ignore_changesso values can be set/rotated out-of-band without Terraform overwriting them
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add parameters for storing the One Login client ID and private key. Don't use them in forms-runner yet as they need to be set to valid values first.
stephencdaly
force-pushed
the
add-parameters-for-one-login-secrets
branch
from
fa496d5 to
8ef4b7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/tKtA1VPQ/
Add parameters for storing the One Login client ID and private key.
Don't use them in forms-runner yet as they need to be set to valid values first.
Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,staging,user-research, and/orprod)apply-forms-terraform-<environment>pipelines have run successfully